Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust-analyzer: 2020-11-09 -> 2021-01-04 #108596

Merged
merged 2 commits into from Jan 7, 2021
Merged

rust-analyzer: 2020-11-09 -> 2021-01-04 #108596

merged 2 commits into from Jan 7, 2021

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Jan 6, 2021

Motivation for this change

Bump version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

prusnak
prusnak requested changes Jan 6, 2021
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

util-linux with the dash is correct; don't replace it

@oxalica
Copy link
Contributor Author

oxalica commented Jan 6, 2021

@prusnak Fixed.

These changes are generated by node2nix. Upstream already select between utillinux and util-linux on master, but prefers utillinux, which seems not good. https://github.com/svanderburg/node2nix/blob/master/nix/node-env.nix#L7

@oxalica oxalica mentioned this pull request Jan 6, 2021
Merged
10 tasks
@ofborg ofborg bot requested a review from midchildan January 6, 2021 19:25
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108596 run on x86_64-linux 1

25 packages built:
  • antora
  • castnow
  • create-cycle-app
  • epgstation
  • etcher
  • gtop
  • joplin
  • netlify-cli
  • parity-ui
  • pm2
  • rambox-pro
  • redoc-cli
  • rust-analyzer
  • rust-analyzer-unwrapped
  • slack
  • teleprompter
  • thelounge
  • vimPlugins.coc-eslint
  • vimPlugins.coc-go
  • vimPlugins.coc-prettier
  • vimPlugins.coc-rust-analyzer
  • vimPlugins.coc-stylelint
  • vimPlugins.coc-vetur
  • vscode-extensions.matklad.rust-analyzer
  • vscode-extensions.ms-python.vscode-pylance

@SuperSandro2000 SuperSandro2000 merged commit 0cfa397 into NixOS:master Jan 7, 2021
@zhaofengli zhaofengli mentioned this pull request Jun 30, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak requested changes

@jonringer jonringer Awaiting requested review from jonringer

@midchildan midchildan Awaiting requested review from midchildan

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxalica @SuperSandro2000 @prusnak