Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libbladeRF: unbreak the build #108595

Merged
merged 1 commit into from Jan 9, 2021
Merged

libbladeRF: unbreak the build #108595

merged 1 commit into from Jan 9, 2021

Conversation

iblech
Copy link
Contributor

@iblech iblech commented Jan 6, 2021 •
edited by SuperSandro2000

Motivation for this change

In current master, libbladeRF is broken because of a (well-justified) compiler warning which breaks the build because we compile with -Werror. The problem has already been fixed in the upstream repository, this pull request cherrypicks the relevant commit.

Be aware that while I tested compilation, I didn't test functionality of libbladeRF. In fact, I don't even know whtat libbladeRF is about.

Closes #108585

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eduardosm
Copy link
Contributor

Result of nixpkgs-review pr 108595 run on x86_64-linux 1

4 packages failed to build:
  • gr-ais
  • gr-gsm
  • gr-osmosdr
  • qradiolink
12 packages built:
  • cubicsdr
  • dump1090
  • gqrx
  • libbladeRF
  • python37Packages.soapysdr-with-plugins
  • python38Packages.soapysdr-with-plugins
  • python39Packages.soapysdr-with-plugins
  • rtl_433
  • sdrangel
  • soapybladerf
  • soapysdr-with-plugins
  • welle-io

@eduardosm
Copy link
Contributor

Failed packages are due to python2.7-cffi failing to build. Looking at the patch, it should not break anything that is not yet broken.

SuperSandro2000
SuperSandro2000 reviewed Jan 6, 2021
View reviewed changes
pkgs/development/libraries/libbladeRF/default.nix Outdated
# The default of libbladeRF, -Werror, is meant for development where there is
# control over the compiler, but in nixpkgs we want to update gcc without
# breaking half the packages due to warnings.
NIX_CFLAGS_COMPILE = [ "-Wno-error" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this if we have the patch?

Copy link
Contributor Author

@iblech iblech Jan 6, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't need this; I picked this up on the suggestion of @Mic92 over at #108585. I don't have a strong opinion on that matter.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do one of the things: the patch or removing -Werror.

Copy link
Contributor Author

@iblech iblech Jan 7, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Please you or somebody else make the call, I'm not experienced enough with our conventions. :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the patch is upstream I would prefer it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks, I'll force-push accordingly in a second. :-)

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 7, 2021 •
edited

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108595 run on x86_64-linux 1

4 packages failed to build and are new build failures:
  • gr-ais: log was empty
  • gr-gsm: log was empty
  • gr-osmosdr: log was empty
  • qradiolink: log was empty
12 packages built:
  • cubicsdr
  • dump1090
  • gqrx
  • libbladeRF
  • python37Packages.soapysdr-with-plugins
  • python38Packages.soapysdr-with-plugins
  • python39Packages.soapysdr-with-plugins
  • rtl_433
  • sdrangel
  • soapybladerf
  • soapysdr-with-plugins
  • welle-io

build failures are unrelated and due to python 2.7 cffi not building which is fixed on staging next IIRC.

@SuperSandro2000 SuperSandro2000 changed the title libbladeRF: unbreak the build (closing #108585) libbladeRF: unbreak the build Jan 7, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108595 run on x86_64-darwin 1

4 packages marked as broken and skipped:
  • gr-ais
  • gr-osmosdr
  • rtl_433
  • welle-io
1 package built:
  • libbladeRF

@SuperSandro2000 SuperSandro2000 merged commit d1f716c into NixOS:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bladerf fails to build
3 participants
@iblech @eduardosm @SuperSandro2000