Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wezterm: add darwin support #108632

Merged
merged 2 commits into from Jan 7, 2021
Merged

wezterm: add darwin support #108632

merged 2 commits into from Jan 7, 2021

Conversation

fanzeyi
Copy link
Contributor

@fanzeyi fanzeyi commented Jan 7, 2021 •
edited

Motivation for this change

Add macOS support for wezterm pkg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 7, 2021
@SuperSandro2000
Copy link
Member

Please change the commit and pr titel to wezterm: add darwin support

@fanzeyi fanzeyi changed the title add darwin support for wezterm XDG_CONFIG_HOME Jan 7, 2021
@fanzeyi fanzeyi changed the title XDG_CONFIG_HOME wezterm: add darwin support Jan 7, 2021
@ofborg ofborg bot requested a review from steveej January 7, 2021 03:05
@fanzeyi
Copy link
Contributor Author

fanzeyi commented Jan 7, 2021

This should be ready to be reviewed. It will produce WezTerm.app at ~/.nix-profile/Applications which aligns with what the package iTerm2.app does.

I don't think I can test sandbox mode on macOS since after I turning it on nix panics with a loader error.

@fanzeyi fanzeyi marked this pull request as ready for review January 7, 2021 04:51
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108632 run on x86_64-linux 1

1 package built:
  • wezterm

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108632 run on x86_64-darwin 1

1 package built:
  • wezterm

@SuperSandro2000 SuperSandro2000 merged commit b139de1 into NixOS:master Jan 7, 2021
@fanzeyi fanzeyi deleted the wezterm-darwin branch January 7, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveej steveej Awaiting requested review from steveej

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fanzeyi @SuperSandro2000 @Janik-Haag