Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] python38: fix find_library patch logic #108601

Closed
wants to merge 1 commit into from
Closed

[staging] python38: fix find_library patch logic #108601

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 6, 2021 •
edited

Motivation for this change

closes #108531

should work if it lands on staging-next as well

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner January 6, 2021 18:02
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python38Packages.cffi

@jonringer jonringer mentioned this pull request Jan 6, 2021
Closed
10 tasks
orivej
orivej approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@FRidh
Copy link
Member

FRidh commented Jan 6, 2021

We won't have a Python 3.8 older than 3.8.7 when the update is done so limiting to below 3.8.7 is not needed.

@peterhoeg
Copy link
Member

Any chance to get this sorted so we can unbreak nixops on unstable?

@jonringer
Copy link
Contributor Author

This shouldn't affect nixops on unstable, IIRC, nixops is still using python2 in nixpkgs

@peterhoeg
Copy link
Member

peterhoeg commented Jan 12, 2021 via email

@jonringer
Copy link
Contributor Author

I think that's a different PR, it's fixed on staging:

[19:59:14] jon@nixos ~/projects/nixpkgs (staging)
$ nix-build -A pythonPackages.cffi
/nix/store/g89a608k243ji97s9knc05k3z6rkyn2x-python2.7-cffi-1.14.4

@jonringer
Copy link
Contributor Author

staging is already at 3.8.7, so this PR is no longer relevant

@jonringer jonringer closed this Jan 13, 2021
@jonringer jonringer deleted the fix-py38-find-utils branch January 13, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

@orivej-nixos orivej-nixos Awaiting requested review from orivej-nixos

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @FRidh @peterhoeg @orivej