Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubyPackages: update #108641

Merged
merged 2 commits into from Jan 7, 2021
Merged

rubyPackages: update #108641

merged 2 commits into from Jan 7, 2021

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 7, 2021

Those packages block regenerating the lock file.
Bundler loops forever

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Jan 7, 2021

Opened nix-community/bundix#77 regarding the editor-config check.

@SuperSandro2000
Copy link
Member

/rebase-staging

@SuperSandro2000
Copy link
Member

Can you please fix the line endings for this PR by hand?

Those packages block regenerating the lock file.
Bundler loops forever
@github-actions github-actions bot changed the base branch from master to staging January 7, 2021 10:04
@Mic92
Copy link
Member Author

Mic92 commented Jan 7, 2021

I am not in favor of that because the next person to regenerate this file will run into the same error.

@SuperSandro2000
Copy link
Member

True but if I merge something with broken editor check I get into problems.

@SuperSandro2000 SuperSandro2000 merged commit 9075da1 into NixOS:staging Jan 7, 2021
@Mic92 Mic92 deleted the ruby-packages branch January 7, 2021 17:57
@Mic92
Copy link
Member Author

Mic92 commented Jan 7, 2021

editor config checks are harmless and here is the PR to fix this properly: nix-community/bundix#78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants