New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nvidia-docker: 2.0.3 -> 2.5.0 #108607
nvidia-docker: 2.0.3 -> 2.5.0 #108607
Conversation
sha256 = "095mks0r4079vawi50pk4zb5jk0g6s9idg2s1w55a0d27jkknldr"; | ||
}}/src"; | ||
preBuild = "go mod init main"; | ||
nativeBuildInputs = [ git ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nativeBuildInputs = [ git ]; |
buildGoModule should already contain git.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this to use buildGoPackage
.
I ended up having to test this in my own config to make sure that |
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM code-wise, but please add yourself as a maintainer.
Could you squash the commits together? |
cad80f1
to
ea2d960
Compare
ea2d960
to
6468f2c
Compare
@SuperSandro2000 I've squashed and added myself as a maintainer. |
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
Thanks @SuperSandro2000! |
Motivation for this change
This change updates
nvidia-docker
to a more recent versionThings done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)I tested by running