Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia-docker: 2.0.3 -> 2.5.0 #108607

Merged
merged 1 commit into from Jan 7, 2021

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Jan 6, 2021

  • nvidia-docker: format drv
  • nvidia-docker: 2.0.3 -> 2.5.0
Motivation for this change

This change updates nvidia-docker to a more recent version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I tested by running

❯ ./result/bin/nvidia-docker run --gpus all --rm -it nvidia/cuda nvidia-smi
Wed Jan  6 19:41:45 2021
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 455.45.01    Driver Version: 455.45.01    CUDA Version: 11.1     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  GeForce RTX 208...  Off  | 00000000:0A:00.0 Off |                  N/A |
| 36%   40C    P0    39W / 250W |      0MiB /  7979MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|  No running processes found                                                 |
+-----------------------------------------------------------------------------+

sha256 = "095mks0r4079vawi50pk4zb5jk0g6s9idg2s1w55a0d27jkknldr";
}}/src";
preBuild = "go mod init main";
nativeBuildInputs = [ git ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nativeBuildInputs = [ git ];

buildGoModule should already contain git.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to use buildGoPackage.

@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 6, 2021

I ended up having to test this in my own config to make sure that docker run --gpus all and docker run --runtime nvidia work, and they do.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108607 run on x86_64-linux 1

1 package built:
  • nvidia-docker

Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise, but please add yourself as a maintainer.

@SuperSandro2000
Copy link
Member

Could you squash the commits together?

@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 7, 2021

@SuperSandro2000 I've squashed and added myself as a maintainer.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108607 run on x86_64-linux 1

1 package built:
  • nvidia-docker

@SuperSandro2000 SuperSandro2000 merged commit 2f2d887 into NixOS:master Jan 7, 2021
@cpcloud cpcloud deleted the update-nvidia-runtime branch January 7, 2021 16:13
@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 7, 2021

Thanks @SuperSandro2000!

@cpcloud cpcloud mentioned this pull request Jan 7, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants