Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: 87.0.4280.88 -> 87.0.4280.141 #108631

Merged
merged 1 commit into from Jan 7, 2021
Merged

Conversation

@TredwellGit TredwellGit added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 7, 2021
@TredwellGit
Copy link
Member Author

I want to know why the hash changed for chromedriver but not the version.

@danielfullmer
Copy link
Contributor

I just ran diffoscope against chromedriver.src from cache.nixos.org and against what I just fetched from https://chromedriver.storage.googleapis.com/87.0.4280.88/chromedriver_linux64.zip:

--- xssshmydphnbbc2hc0r4gmn9ixsf3byx-chromedriver_linux64.zip
+++ chromedriver_linux64.zip
├── zipinfo {}
│ @@ -1,3 +1,3 @@
│  Zip file size: 6121623 bytes, number of entries: 1
│ --rwxr-xr-x  3.0 unx 12405080 bx defN 20-Dec-03 18:14 chromedriver
│ +-rwxr-xr-x  3.0 unx 12405080 bx defN 21-Jan-06 20:30 chromedriver
│  1 file, 12405080 bytes uncompressed, 6121449 bytes compressed:  50.7%

Luckily, there isn't any difference between the chromedriver executable contained in each version. It just looks like the timestamp changed....

@danielfullmer
Copy link
Contributor

It looks like this also happened in December as well: #106272

@danielfullmer
Copy link
Contributor

Built and tested chromium on x86_64-linux.

@primeos primeos merged commit d027c59 into NixOS:master Jan 7, 2021
@TredwellGit TredwellGit deleted the chromium branch January 7, 2021 12:02
@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants