Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak assorted python3 packages #107903

Merged
merged 12 commits into from Dec 31, 2020
Merged

Unbreak assorted python3 packages #107903

merged 12 commits into from Dec 31, 2020

Conversation

rmcgibbo
Copy link
Contributor

Motivation for this change

Unbreak various packages that I noticed were currently broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Dec 30, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/development/python-modules/clifford/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/clifford/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/imageio-ffmpeg/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/imbalanced-learn/default.nix Outdated Show resolved Hide resolved
@marcus7070
Copy link
Member

1db5bd7 (the spyder-kernels_0_5 fix) was done in #107806 a few hours ago.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107903 run on x86_64-linux 1

1 package marked as broken and skipped:
  • python37Packages.rl-coach
17 packages failed to build:
  • python37Packages.aplpy
  • python37Packages.datashader
  • python37Packages.flower
  • python37Packages.geopandas
  • python37Packages.mask-rcnn
  • python37Packages.osmnx
  • python37Packages.spectral-cube
  • python37Packages.sunpy
  • python38Packages.aplpy
  • python38Packages.datashader
  • python38Packages.flower
  • python38Packages.geopandas
  • python38Packages.imgaug
  • python38Packages.mask-rcnn
  • python38Packages.osmnx
  • python38Packages.spectral-cube
  • python38Packages.sunpy
82 packages built:
  • cq-editor
  • cura
  • gns3-gui
  • gns3-server
  • octoprint
  • python37Packages.alerta-server
  • python37Packages.batchgenerators
  • python37Packages.billiard
  • python37Packages.caffe
  • python37Packages.cartopy
  • python37Packages.celery
  • python37Packages.clifford
  • python37Packages.dask-image
  • python37Packages.datasets
  • python37Packages.django-raster
  • python37Packages.djmail
  • python37Packages.fastparquet
  • python37Packages.fiona
  • python37Packages.glymur
  • python37Packages.handout
  • python37Packages.image-match
  • python37Packages.imagecorruptions
  • python37Packages.imageio
  • python37Packages.imageio-ffmpeg
  • python37Packages.imbalanced-learn
  • python37Packages.imgaug
  • python37Packages.moviepy
  • python37Packages.pims
  • python37Packages.runway-python
  • python37Packages.scikitimage
  • python37Packages.sentry-sdk
  • python37Packages.spyder-kernels_0_5
  • python37Packages.spyder_3
  • python37Packages.stytra
  • python37Packages.test-tube
  • python38Packages.alerta-server
  • python38Packages.batchgenerators
  • python38Packages.billiard
  • python38Packages.caffe
  • python38Packages.cartopy
  • python38Packages.celery
  • python38Packages.clifford
  • python38Packages.dask-image
  • python38Packages.datasets
  • python38Packages.django-raster
  • python38Packages.djmail
  • python38Packages.fastparquet
  • python38Packages.fiona
  • python38Packages.glymur
  • python38Packages.handout
  • python38Packages.image-match
  • python38Packages.imagecorruptions
  • python38Packages.imageio
  • python38Packages.imageio-ffmpeg
  • python38Packages.imbalanced-learn
  • python38Packages.moviepy
  • python38Packages.pims
  • python38Packages.runway-python
  • python38Packages.scikitimage
  • python38Packages.sentry-sdk
  • python38Packages.spyder-kernels_0_5
  • python38Packages.spyder_3
  • python38Packages.stytra
  • python38Packages.test-tube
  • python39Packages.billiard
  • python39Packages.cartopy
  • python39Packages.fiona
  • python39Packages.handout
  • python39Packages.imageio
  • python39Packages.imageio-ffmpeg
  • python39Packages.moviepy
  • sourcehut.buildsrht
  • sourcehut.dispatchsrht
  • sourcehut.gitsrht
  • sourcehut.hgsrht
  • sourcehut.hubsrht
  • sourcehut.listssrht
  • sourcehut.mansrht
  • sourcehut.metasrht
  • sourcehut.pastesrht
  • sourcehut.todosrht
  • tartube

@rmcgibbo
Copy link
Contributor Author

@jonringer, @marcus7070: review comments addressed in latest set of force pushes.

@ofborg ofborg bot requested a review from arnoldfarkas December 30, 2020 23:37
@FRidh
Copy link
Member

FRidh commented Dec 31, 2020

Thank you. Now I may try using datashader again :)

@FRidh FRidh merged commit d02e895 into NixOS:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@danieldk danieldk Awaiting requested review from danieldk

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

@veprbl veprbl Awaiting requested review from veprbl

@pmiddend pmiddend Awaiting requested review from pmiddend

@gebner gebner Awaiting requested review from gebner

@marcus7070 marcus7070 Awaiting requested review from marcus7070

@costrouc costrouc Awaiting requested review from costrouc

@arnoldfarkas arnoldfarkas Awaiting requested review from arnoldfarkas

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rmcgibbo @marcus7070 @SuperSandro2000 @FRidh @jonringer