New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prometheus-smokeping-prober: init at 0.3.1 from git #107891
Conversation
Result of 1 package built:
|
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it out on my Prometheus instance and smokeping worked perfectly. 👍
Also, successfully executed tests:
$ nix-build -vA pkgs.nixosTests.prometheus-exporters.smokeping
...
test script finished in 11.12s
6f0916b
to
3297ac7
Compare
This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC. Result of 1 package blacklisted:
1 package built:
|
Result of 1 package built:
|
Motivation for this change
Add https://github.com/SuperQ/smokeping_prober, a Prometheus exporter similar to blackbox exporter but which manages its own ping schedule (and thus is more suitable for continuous monitoring, as a replacement for smokeping).
This uses the version at HEAD from git since a release hasn't been cut in a while and we'd ideally like the recent improvements to go-ping.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)