nixos/corerad: use pkgs.formats.toml to generate TOML configuration #107900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg test corerad |
infinisil
requested changes
Dec 29, 2020
Signed-off-by: Matt Layher <mdlayher@gmail.com>
|
@GrahamcOfBorg test corerad |
infinisil
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matt Layher mdlayher@gmail.com
Motivation for this change
Remove bespoke JSON to TOML converter in favor of the new
pkgs.formats.tomloption to generate the CoreRAD configuration file from Nix attributes.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)/cc @jonringer @infinisil since you've reviewed these types of things in the past and Infinisil has worked on RFC 42.