Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.advantage_air: init at 0.2.1 #107894

Merged
merged 2 commits into from Jan 7, 2021
Merged

pythonPackages.advantage_air: init at 0.2.1 #107894

merged 2 commits into from Jan 7, 2021

Conversation

JamieMagee
Copy link
Member

@JamieMagee JamieMagee commented Dec 29, 2020 •
edited

Motivation for this change

Support the advantage_air component in Home Assistant.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107894 run on x86_64-linux 1

3 packages built:
  • python37Packages.advantage_air
  • python38Packages.advantage_air
  • python39Packages.advantage_air

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107894 run on x86_64-darwin 1

3 packages built:
  • python37Packages.advantage_air
  • python38Packages.advantage_air
  • python39Packages.advantage_air

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107894 run on x86_64-linux 1

3 packages built:
  • python37Packages.advantage-air
  • python38Packages.advantage-air
  • python39Packages.advantage-air

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107894 run on x86_64-darwin 1

3 packages built:
  • python37Packages.advantage-air
  • python38Packages.advantage-air
  • python39Packages.advantage-air

@SuperSandro2000 SuperSandro2000 merged commit e0f22de into NixOS:master Jan 7, 2021
@JamieMagee JamieMagee deleted the advantage_air branch September 3, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff left review comments

@mweinelt mweinelt mweinelt left review comments

@jonringer jonringer jonringer left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JamieMagee @SuperSandro2000 @fabaff @mweinelt @jonringer