Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/prometheus: add gce_sd_configs scrapeConfig option #107895

Merged
merged 5 commits into from Jan 11, 2021

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Dec 29, 2020

Motivation for this change

I'd like to discover Prometheus targets on VMs running in Google Compute Engine

Things done

Added the gce_sd_configs/gce_sd_config types to the nixos/prometheus
module's scrapeConfig option.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 10, 2021

@SuperSandro2000 Can this be merged?

@SuperSandro2000
Copy link
Member

@SuperSandro2000 Can this be merged?

I am not that familiar with modules.

@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 10, 2021

@Mic92 I have addressed your review comments! Thanks for the review.

@Mic92 Mic92 merged commit 89593ae into NixOS:master Jan 11, 2021
@cpcloud cpcloud deleted the prom-gce-sd-config branch January 11, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants