Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/prometheus: update relabel_action list #107890

Merged
merged 1 commit into from Jan 3, 2021

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Dec 29, 2020

Motivation for this change

Prometheus has additional relabel actions that are not reflected in the NixOS module.

See here for details

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@urbas urbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this change out on my Prometheus instance (on an RPi 4). Looks good to me. 👍

@cpcloud
Copy link
Contributor Author

cpcloud commented Dec 30, 2020

@SuperSandro2000 Can this be merged?

@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 3, 2021

@SuperSandro2000 I've added your suggested change and rebased. Can this be merged?

@Ma27 Ma27 merged commit a6e5071 into NixOS:master Jan 3, 2021
@Ma27
Copy link
Member

Ma27 commented Jan 3, 2021

Ported to stable as b03d740.

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Jan 3, 2021
@cpcloud cpcloud deleted the prom-more-relabel-actions branch January 3, 2021 19:29
@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 3, 2021

@Ma27 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants