Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt514.qtwebkit: Fix patch applying #107898

Merged
merged 1 commit into from Jan 2, 2021
Merged

qt514.qtwebkit: Fix patch applying #107898

merged 1 commit into from Jan 2, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 requested a review from a user December 29, 2020 18:42
@SuperSandro2000 SuperSandro2000 mentioned this pull request Dec 29, 2020
Merged
10 tasks
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 107898 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • libsForQt514.alkimia
  • multibootusb
2 packages failed to build:
  • mindforger
  • subsurface
2 packages built:
  • phantomjs2
  • qt514.qtwebkit

@ttuegel
Copy link
Member

ttuegel commented Dec 30, 2020

What's going on here?

@SuperSandro2000
Copy link
Member Author

The patch fails to apply because there is no file named Source/WTF/wtf/PlatformMac.cmake and I could not find a similar file.

@ttuegel ttuegel merged commit eed06a0 into NixOS:master Jan 2, 2021
@SuperSandro2000 SuperSandro2000 deleted the qtwebkit-darwin branch August 26, 2021 09:39
@prusnak prusnak mentioned this pull request Dec 11, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @ttuegel