New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hub: Add test, git reference #107887
hub: Add test, git reference #107887
Conversation
Hub fetches git from the environment by default. This can lead to hub installations without git available, which makes little sense. The change replaces the references with fully-qualified calls to git
Result of 1 package built:
|
Result of 1 package built:
|
Result of 1 package built:
Working fine and code LGTM |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
@NeQuissimus Is there a reason you're not using |
It's mainly because @ofborg runs these tests for us if they are in |
None of that is needed with |
Motivation for this change
Added test, found an issue with git not being available.
This is due to
hub
assuming git exists in the environment.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)