Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lutris 5.7.1 to 5.8.1 #107130

Closed
wants to merge 2 commits into from
Closed

lutris 5.7.1 to 5.8.1 #107130

wants to merge 2 commits into from

Conversation

JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Dec 18, 2020 •
edited

Motivation for this change

I wanted to get the latest version of Lutris.

Things done

Updated the version of Lutris and added me as a maintainer of this package.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JeffLabonte JeffLabonte marked this pull request as draft December 18, 2020 04:04
jonringer
jonringer reviewed Dec 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

lutris: 5.7.1 -> 5.8.1

@JeffLabonte
Copy link
Contributor Author

@jonringer This is one of the reasons, I have put this on draft. Lutris is also unable to find vulkan.

@ofborg ofborg bot requested a review from Chiiruno December 19, 2020 23:48
@jonringer
Copy link
Contributor

there was always a warning, but most games launched fine

@JeffLabonte
Copy link
Contributor Author

JeffLabonte commented Dec 22, 2020 •
edited

@jonringer I am currently using the package to play some of my games, but the updated version isn't able to access the Vulkan libraries.

It would have made things easier it would have just given me a warning.

@jonringer
Copy link
Contributor

I must not be playing any games using vulkan then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@Chiiruno Chiiruno Awaiting requested review from Chiiruno

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JeffLabonte @jonringer