CargoSpec array cleanup #8392
Merged
CargoSpec array cleanup #8392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaroth
force-pushed
the
cargospec_cleanup
branch
from
da91033 to
e37a9bb
Compare
glx22
reviewed
Dec 16, 2020
|
Renaming |
Xaroth
force-pushed
the
cargospec_cleanup
branch
from
e37a9bb to
fb8ad59
Compare
LordAro
reviewed
Dec 17, 2020
|
You're probably not going to want to hear this, but NML could do with some renaming too... Though compatibility will need to be maintained there (not that that's difficult) |
Xaroth
force-pushed
the
cargospec_cleanup
branch
from
fb8ad59 to
fc30004
Compare
LordAro
reviewed
Dec 17, 2020
Xaroth
force-pushed
the
cargospec_cleanup
branch
from
fc30004 to
38b28fa
Compare
LordAro
approved these changes
Dec 17, 2020
Xaroth
added a commit
to Xaroth/nml
that referenced
this pull request
Dec 18, 2020
Xaroth
added a commit
to Xaroth/nml
that referenced
this pull request
Dec 18, 2020
TrueBrain
added
candidate: yes
|
@LordAro : can this be merged before OpenTTD/nml#176 is approved, or is it blocking on it? |
frosch123
pushed a commit
to OpenTTD/nml
that referenced
this pull request
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current default CargoSpec list is very (very) verbose, making it very difficult to read what is going on. This PR tries to improve readability by doing some (albeit not-very-pretty) macro work.
This comes with some changes in sprite names and string names to make sure they all match the same format. Since I was not 100% sure on how to deal with the renaming of strings for other translations, I moved those to a separate commit, keeping only the changes to English in the main commit.