Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zstd: 1.4.5 -> 1.4.8 #107132

Merged
merged 1 commit into from Dec 30, 2020
Merged

zstd: 1.4.5 -> 1.4.8 #107132

merged 1 commit into from Dec 30, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 18, 2020

Motivation for this change

https://github.com/facebook/zstd/releases/tag/v1.4.7

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Atemu Atemu mentioned this pull request Dec 18, 2020
Closed
10 tasks
@Atemu
Copy link
Member

Atemu commented Dec 18, 2020

Needs to go to staging, zstd is way down the dependency tree.

@marsam marsam marked this pull request as draft December 18, 2020 05:57
@marsam marsam changed the base branch from master to staging December 18, 2020 05:58
@marsam marsam marked this pull request as ready for review December 18, 2020 05:59
@marsam marsam changed the title zstd: 1.4.5 -> 1.4.7 zstd: 1.4.5 -> 1.4.8 Dec 20, 2020
@mweinelt mweinelt added this to WIP in Staging via automation Dec 22, 2020
TredwellGit
TredwellGit approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@TredwellGit TredwellGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebuilt my system with this.

@marsam marsam merged commit d07c724 into NixOS:staging Dec 30, 2020
Staging automation moved this from WIP to Done Dec 30, 2020
@marsam marsam deleted the update-zstd branch December 30, 2020 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TredwellGit TredwellGit TredwellGit approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @Atemu @TredwellGit