Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/manual: fix typo in virtualbox installation guide #107134

Merged
merged 1 commit into from Dec 21, 2020
Merged

nixos/manual: fix typo in virtualbox installation guide #107134

merged 1 commit into from Dec 21, 2020

Conversation

psibi
Copy link
Member

@psibi psibi commented Dec 18, 2020

Motivation for this change

Fixes a minor issue in the manual regarding installation inside virtualbox.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Dec 18, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the title/commit message to something like:

nixos/manual: fix typo in virtualbox installation guide

?

@psibi
Copy link
Member Author

psibi commented Dec 21, 2020

@SuperSandro2000 Done.

@SuperSandro2000 SuperSandro2000 changed the title /s/no/not : Documentation manual fix in virtualbox installation nixos/manual: fix typo in virtualbox installation guide Dec 21, 2020
@SuperSandro2000 SuperSandro2000 merged commit 652da3f into NixOS:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@psibi @SuperSandro2000