Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xxHash: fix static build #108117

Merged
merged 1 commit into from Jan 4, 2021
Merged

xxHash: fix static build #108117

merged 1 commit into from Jan 4, 2021

Conversation

KAction
Copy link
Contributor

@KAction KAction commented Jan 1, 2021

Patch upstream Makefile to not attempt to build dynamic library if host
platform is static only (pkgsStatic).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@orivej

xxHash: fix static build
9e253f3 
Patch upstream Makefile to not attempt to build dynamic library if host
platform is static only (pkgsStatic).
@SuperSandro2000
Copy link
Member

Please target staging with the over 1000 rebuilds.

@FRidh FRidh changed the base branch from master to staging January 4, 2021 17:13
@FRidh FRidh merged commit efb7e1b into NixOS:staging Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KAction @SuperSandro2000 @FRidh