Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solanum: init at unstable-2020-12-14 #108164

Merged
merged 1 commit into from Jan 3, 2021
Merged

solanum: init at unstable-2020-12-14 #108164

merged 1 commit into from Jan 3, 2021

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Jan 1, 2021

Motivation for this change

Solanum is a fork of charybdis maintained by freenode and OFTC.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt requested a review from andir January 1, 2021 20:50
@mweinelt mweinelt force-pushed the solanum branch 2 times, most recently from b3e25e9 to 77f4692 Compare January 1, 2021 21:55
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108164 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • solanum
----------------------------------------------------------------------
make[3]: Leaving directory '/build/source/extensions'
make[2]: Leaving directory '/build/source/extensions'
Making install in help
make[2]: Entering directory '/build/source/help'
building index files
/nix/store/4l7wsi6h6283194r6fqy1731qxlagq62-bash-4.4-p23/bin/bash: line 4: column: command not found
/nix/store/4l7wsi6h6283194r6fqy1731qxlagq62-bash-4.4-p23/bin/bash: line 4: column: command not found
tr: write error: Broken pipe
ircd: setting up help directory structure
make[2]: Leaving directory '/build/source/help'
Making install in doc
make[2]: Entering directory '/build/source/doc'
mkdir -p /nix/store/ypmpcc53xxld1izhkxfichj6bcc2ppmw-solanum-unstable-2020-12-14/etc
ircd: installing example config files (ircd.conf.example reference.conf)
ircd: installing motd file (ircd.motd)
make[2]: Leaving directory '/build/source/doc'
make[2]: Entering directory '/build/source'
make[3]: Entering directory '/build/source'
make  install-exec-hook
make[4]: Entering directory '/build/source'
rm -f /nix/store/ypmpcc53xxld1izhkxfichj6bcc2ppmw-solanum-unstable-2020-12-14/lib/*.la
rm -f /nix/store/ypmpcc53xxld1izhkxfichj6bcc2ppmw-solanum-unstable-2020-12-14/lib/solanum/modules/*.la
rm -f /nix/store/ypmpcc53xxld1izhkxfichj6bcc2ppmw-solanum-unstable-2020-12-14/lib/solanum/modules/autoload/*.la
rm -f /nix/store/ypmpcc53xxld1izhkxfichj6bcc2ppmw-solanum-unstable-2020-12-14/lib/solanum/modules/extensions/*.la
rm -f /nix/store/ypmpcc53xxld1izhkxfichj6bcc2ppmw-solanum-unstable-2020-12-14/lib/*.dll.a
rm -f /nix/store/ypmpcc53xxld1izhkxfichj6bcc2ppmw-solanum-unstable-2020-12-14/lib/solanum/modules/*.dll.a
rm -f /nix/store/ypmpcc53xxld1izhkxfichj6bcc2ppmw-solanum-unstable-2020-12-14/lib/solanum/modules/autoload/*.dll.a
rm -f /nix/store/ypmpcc53xxld1izhkxfichj6bcc2ppmw-solanum-unstable-2020-12-14/lib/solanum/modules/extensions/*.dll.a
make[4]: Leaving directory '/build/source'
make  install-data-hook
make[4]: Entering directory '/build/source'
test -d /var/lib/solanum/log/solanum || mkdir -p /var/lib/solanum/log/solanum
mkdir: cannot create directory '/var': Permission denied
make[4]: *** [Makefile:921: install-data-hook] Error 1
make[4]: Leaving directory '/build/source'
make[3]: *** [Makefile:834: install-data-am] Error 2
make[3]: Leaving directory '/build/source'
make[2]: *** [Makefile:785: install-am] Error 2
make[2]: Leaving directory '/build/source'
make[1]: *** [Makefile:475: install-recursive] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:778: install] Error 2

@mweinelt
Copy link
Member Author

mweinelt commented Jan 1, 2021

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108164 run on x86_64-linux 1
1 package failed to build and are new build failure:

[...]
make[4]: Leaving directory '/build/source'
make  install-data-hook
make[4]: Entering directory '/build/source'
test -d /var/lib/solanum/log/solanum || mkdir -p /var/lib/solanum/log/solanum
mkdir: cannot create directory '/var': Permission denied
[...]
make: *** [Makefile:778: install] Error 2

Resolved in 4a0ea18

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108164 run on x86_64-linux 1

1 package built:
  • solanum

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108164 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • solanum

@mweinelt
Copy link
Member Author

mweinelt commented Jan 2, 2021

Result of nixpkgs-review pr 108164 run on x86_64-darwin 1
1 package marked as broken and skipped:

Surprising, must be due to a dependency. Probably lksctp-tools.

@mweinelt mweinelt force-pushed the solanum branch 2 times, most recently from 3e5042a to ee7be42 Compare January 2, 2021 03:37
@mweinelt
Copy link
Member Author

mweinelt commented Jan 2, 2021

I made SCTP support conditional on stdenv.isLinux.

@SuperSandro2000

This comment has been minimized.

Sign in to view
@mweinelt
Copy link
Member Author

mweinelt commented Jan 2, 2021

Not many details, added __darwinAllowLocalNetworking = true; for good measure.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or torch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108164 run on x86_64-linux 1

1 package built:
  • solanum

@SuperSandro2000
Copy link
Member

failing tests on darwin:

rm -rf runtime/modules && mkdir -p runtime/modules/autoload
for f in ../modules/core/.libs/*.so; do ln -s "../../../modules/core/.libs/${f##*/}" "runtime/modules/${f##*/}"; done
for f in ../modules/.libs/*.so; do ln -s "../../../../modules/.libs/${f##*/}" "runtime/modules/autoload/${f##*/}"; done
ASAN_OPTIONS=":detect_leaks=false" ./runtests -l /private/tmp/nix-build-solanum-unstable-2020-12-14.drv-0/source/tests/TESTS

Running all tests listed in TESTS.  If any tests fail, run the failing
test program with runtests -o to see more details.

chmode1.........................ok
match1..........................ok
msgbuf_parse1...................ok
msgbuf_unparse1.................FAILED 343, 349, 351, 355
hostmask1.......................ok
rb_dictionary1..................ok
rb_snprintf_append1.............ok
rb_snprintf_try_append1.........ok
sasl_abort1.....................ok
send1...........................FAILED 21, 24, 81, 84, 87, 90, 93, 96, 99, 102, 141, 144, 150, 153, 177, 180, 186, 189, 452, 455, 470, 473, 487, 490, 504, 507, 946, 949, 958, 961, 1091, 1094, 1101, 1104, 1230, 1233, 1249, 1262, 1265, 1276, 1279, 1305, 1315, 1327, 1337, 1500, 1513, 1526, 1529, 1555, 1567, 1580, 1591, 1602, 1605, 1616, 1629, 1640, 1643, 1780, 1793, 1806, 1809, 1835, 1849, 1864, 1877, 1888, 1891, 2036, 2039, 2055, 2070, 2073, 2099, 2113, 2124, 2127, 2138, 2141, 2152, 2155, 2271, 2285, 2299, 2302, 2330, 2340, 2350, 2368, 2505, 2520, 2770, 2773, 2812, 2815, 2850, 2853, 2892, 2895, 3090, 3093, 3132, 3135, 3170, 3173, 3212, 3215, 3508, 3532, 3545, 3591, 3596, 3667, 3672, 3676, 3681, 3685, 3689, 3693, 3698, 3702, 3707, 3711, 3715, 3992, 4008, 4016, 4032, 4038, 4058, 4068, 4088, 4096, 4116, 4126, 4146, 4154, 4176, 4187, 4209, 4310, 4326, 4333, 4349, 4357, 4373, 4380, 4396, 4443, 4446, 4456, 4459, 4470, 4517, 4520, 4530, 4533, 4544
send_multiline1.................ok
serv_connect1...................FAILED 5, 8, 12
substitution1...................ok

Failed Set                 Fail/Total (%) Skip Stat  Failing Tests
-------------------------- -------------- ---- ----  ------------------------
msgbuf_unparse1               4/355    1%    0    0  343, 349, 351, 355
send1                       159/4636   3%    0    0  21, 24, 81, 84, 87, ...
serv_connect1                 3/16    19%    0    0  5, 8, 12

Failed 166/7004 tests, 97.63% okay.
Files=13,  Tests=7004,  3.39 seconds (0.40 usr + 1.69 sys = 2.09 CPU)
make[3]: *** [Makefile:934: check-local] Error 1
make[3]: Leaving directory '/private/tmp/nix-build-solanum-unstable-2020-12-14.drv-0/source/tests'
make[2]: *** [Makefile:757: check-am] Error 2
make[2]: Leaving directory '/private/tmp/nix-build-solanum-unstable-2020-12-14.drv-0/source/tests'
make[1]: *** [Makefile:475: check-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-solanum-unstable-2020-12-14.drv-0/source'
make: *** [Makefile:773: check] Error 2

@mweinelt
solanum: init at unstable-2020-12-14
6a2c5d1 
Solanum is a fork of charybdis maintained by freenode and OFTC.
@mweinelt
Copy link
Member Author

mweinelt commented Jan 2, 2021 •
edited

Disabled tests on darwin, it is how it is. Not super important.

Thanks for testing!

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108164 run on x86_64-linux 1

1 package built:
  • solanum

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108164 run on x86_64-darwin 1

1 package built:
  • solanum

@SuperSandro2000 SuperSandro2000 merged commit 115dc31 into NixOS:master Jan 3, 2021
@mweinelt mweinelt deleted the solanum branch January 7, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @SuperSandro2000 @andir