Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elfx86exts: init at 0.4.3 #108165

Merged
merged 1 commit into from Jan 1, 2021
Merged

elfx86exts: init at 0.4.3 #108165

merged 1 commit into from Jan 1, 2021

Conversation

rmcgibbo
Copy link
Contributor

@rmcgibbo rmcgibbo commented Jan 1, 2021

Motivation for this change

Not strictly a neceesary package, but it seems useful for inspecting x86 binaries. I used this in the context of https://discourse.nixos.org/t/supported-instruction-sets/10755

Repology indicates that it's only in the AUR, so I'm not 100% sure if it suits our criterion for inclusion or not.
https://repology.org/project/elfx86exts/versions

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • X ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108165 run on x86_64-linux 1

1 package built:
  • elfx86exts

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108165 run on x86_64-darwin 1

1 package built:
  • elfx86exts

@SuperSandro2000 SuperSandro2000 merged commit 881346e into NixOS:master Jan 1, 2021
@rmcgibbo rmcgibbo deleted the elfx86exts branch January 1, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants