Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentabletdriver: misc improvements to package/module #108131

Merged
merged 2 commits into from Jan 5, 2021
Merged

opentabletdriver: misc improvements to package/module #108131

merged 2 commits into from Jan 5, 2021

Conversation

thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Jan 1, 2021 •
edited

Motivation for this change
  • In opentabletdriver package, use install instead of cp when possible, making the install process more deterministic (i.e.: ensure that the permissions are correct) and avoiding useless mkdir commands
  • Add hardware.opentabletdriver.package option, allowing using of a custom OpenTabletDriver package
  • Add missing hooks
  • Use copyDesktopItems instead of copying it manually
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

thiagokokada
thiagokokada commented Jan 1, 2021
View reviewed changes
pkgs/tools/X11/opentabletdriver/default.nix

cp -r $src/OpenTabletDriver.UX/Assets/* $out/share/pixmaps
mkdir -p $out/lib/OpenTabletDriver
cp -rv ./OpenTabletDriver/Configurations $out/lib/OpenTabletDriver
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install doesn't support recursive directory copy.

@thiagokokada thiagokokada marked this pull request as ready for review January 1, 2021 21:24
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/422

@thiagokokada
opentabletdriver: misc improvements
0a14936 
- Use install instead of cp when possible
- Add missing hooks
- Use desktopItem instead of packaging desktop file manually
@thiagokokada
nixos/opentabletdriver: add package option
a239105
@thiagokokada
Copy link
Contributor Author

@SuperSandro2000 Can I have your review here? Should be a pretty uncontroversial one.

@thiagokokada
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 4, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@vikanezrimaya
Copy link
Member

LGTM. I don't think this can break something.

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from kevincox January 5, 2021 13:15
@thiagokokada
Copy link
Contributor Author

Result of nixpkgs-review pr 108131 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:
  • opentabletdriver

@kevincox kevincox merged commit e10ef1f into NixOS:master Jan 5, 2021
@thiagokokada thiagokokada deleted the opentabletdriver-misc-improvements branch January 5, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikanezrimaya vikanezrimaya Awaiting requested review from vikanezrimaya

@kevincox kevincox Awaiting requested review from kevincox

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thiagokokada @nixos-discourse @vikanezrimaya @kevincox