Skip to content

zigbee2mqtt: 1.16.2 -> 1.17.0 #108130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2021
Merged

zigbee2mqtt: 1.16.2 -> 1.17.0 #108130

merged 1 commit into from
Jan 2, 2021
+2,181 −592

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Jan 1, 2021

Motivation for this change

https://github.com/Koenkk/zigbee2mqtt/releases/tag/1.17.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mweinelt
zigbee2mqtt: 1.16.2 -> 1.17.0

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
ae64bc6 
https://github.com/Koenkk/zigbee2mqtt/releases/tag/1.17.0
@mweinelt mweinelt requested review from makefu and zaninime January 1, 2021 14:29
@ofborg ofborg bot requested a review from sweber83 January 1, 2021 14:54
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 1, 2021
makefu
makefu approved these changes Jan 1, 2021
View reviewed changes
Copy link
Contributor

@makefu makefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Haven't run the test though :)
@mweinelt, have you tested the new version with your zigbee2mqtt deployment?

@mweinelt
Copy link
Member Author

mweinelt commented Jan 1, 2021

I have not.

@SuperSandro2000
Copy link
Member

When running nixpkgs-review I get:

Automatic merge went well; stopped before committing as requested
error: stack overflow (possible infinite recursion)
nix --experimental-features nix-command eval --json --impure --expr (import /nix/store/a2830lip28sdarkfqqwq1z0jvxg7xx6p-nixpkgs-review-2.5.0/lib/python3.8/site-packages/nixpkgs_review/nix/evalAttrs.nix /tmp/tmp6fwe58ny) failed to run, /tmp/tmp6fwe58ny was stored inspection
https://github.com/NixOS/nixpkgs/pull/108130 failed to build

@zaninime
Copy link
Contributor

zaninime commented Jan 1, 2021

Works in my deployment. Starts and all the devices are connected successfully.

@markuskowa
Copy link
Member

Result of nixpkgs-review pr 108130 1

1 package built:
  • zigbee2mqtt

@markuskowa markuskowa merged commit 43933d2 into NixOS:master Jan 2, 2021
@mweinelt mweinelt deleted the zigbee2mqtt branch January 2, 2021 14:57
@FRidh
Copy link
Member

FRidh commented Jan 3, 2021 •
edited
Loading

Reverted in aaf4ddd because of an infinite recursion.

@FRidh
Copy link
Member

FRidh commented Jan 3, 2021 •
edited
Loading

We can check Nix versions here:

  • I got the issue with 2.4pre20201201_5a6ddb3 error: stack overflow (possible infinite recursion)
  • Hydra had the issue with nix-2.4pre20201118_79aa7d9 error: unexpected end-of-file
  • 2.3.10 on nixos-unstable error: unexpected end-of-file
  • 2.3.9 on nixos-20.09 error: unexpected end-of-file
  • 2.3.6 on nixos-20.03 error: unexpected end-of-file

Also regarding tail call optimization NixOS/nix#1150.

Adjusting ulimit resolves the issue NixOS/nix#3821 (comment), NixOS/nix#3462 (comment). Derivation is 5 MB, which is pretty huge. Old version is 3.2 MB. Upstream issue svanderburg/node2nix#46.

This was referenced Jan 3, 2021
Closed
Open
@mweinelt mweinelt mentioned this pull request Mar 3, 2021
Closed
10 tasks
@mweinelt mweinelt mentioned this pull request Jul 26, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makefu makefu

@zaninime zaninime

@sweber83 sweber83

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mweinelt @SuperSandro2000 @zaninime @markuskowa @FRidh @makefu