Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/plasma5: synchronize Qt version with all-packages.nix #108128

Merged
merged 1 commit into from Jan 2, 2021
Merged

nixos/plasma5: synchronize Qt version with all-packages.nix #108128

merged 1 commit into from Jan 2, 2021

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Jan 1, 2021 •
edited

Motivation for this change

Synchronize the Qt version used by Nixpkgs and NixOS for Plasma 5. This will reduce the closure size and probably fixes some latent bugs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ttuegel ttuegel merged commit f69c648 into NixOS:master Jan 2, 2021
@ttuegel ttuegel deleted the plasma-sync-qt-version branch January 2, 2021 11:47
ttuegel added a commit to ttuegel/nixpkgs that referenced this pull request Jan 2, 2021
@ttuegel
Merge pull request NixOS#108128 from ttuegel/plasma-sync-qt-version
c53ed46 
nixos/plasma5: synchronize Qt version with all-packages.nix

(cherry picked from commit f69c648)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 6.topic: qt/kde 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ttuegel