Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Qt 5.14 #108129

Closed
wants to merge 1 commit into from
Closed

Remove Qt 5.14 #108129

wants to merge 1 commit into from

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Jan 1, 2021

Motivation for this change

Qt 5.14 is no longer supported upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This can't be removed yet because it would break a lot of programs on darwin cause we can't use 5.15 there because we need to update the apple sdk.

@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review January 1, 2021 18:43
@SuperSandro2000 SuperSandro2000 marked this pull request as draft January 1, 2021 18:43
@ttuegel
Copy link
Member Author

ttuegel commented Jan 1, 2021

This can't be removed yet because it would break a lot of programs on darwin cause we can't use 5.15 there because we need to update the apple sdk.

This being the case, then we need to move macOS back to a version that still has upstream support (Qt 5.12.9).

@NixOS/qt-kde Are any of the current maintainers using Darwin?

@FRidh
Copy link
Member

FRidh commented Jan 1, 2021

There's an increasing amount of packages for which the new sdk is needed.

I don't use darwin.

@SuperSandro2000
Copy link
Member

This being the case, then we need to move macOS back to a version that still has upstream support (Qt 5.12.9).

This could break some packages. Maybe we can wait until the SDK update is in.

@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@ttuegel ttuegel closed this Jul 21, 2021
@willcohen
Copy link
Contributor

willcohen commented Apr 13, 2022

@ttuegel looking at this a little further -- how would you feel about bumping darwin's default Qt from 5.12 to 5.14? The justification given earlier in this PR is that 5.12 still had LTS support, while 5.14 was unsupported. At this point, 5.12 is no longer supported either. Given two non-ideal situations, maybe it's still at least better to get darwin by default up to 5.14 so it's running on a circa-2019 EOL library rather than a circa-2018 EOL library.

@ttuegel
Copy link
Member Author

ttuegel commented Apr 13, 2022

That's probably a good idea!

@willcohen
Copy link
Contributor

PR at: #168524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: qt/kde
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants