Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minikube: 1.15.1 -> 1.16.0 #108085

Merged
merged 1 commit into from Jan 5, 2021
Merged

minikube: 1.15.1 -> 1.16.0 #108085

merged 1 commit into from Jan 5, 2021

Conversation

Chili-Man
Copy link
Contributor

@Chili-Man Chili-Man commented Dec 31, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

thiagokokada
thiagokokada reviewed Jan 1, 2021
View reviewed changes
pkgs/applications/networking/cluster/minikube/default.nix Outdated
@@ -13,15 +13,15 @@ buildGoModule rec {
pname = "minikube";
version = "1.15.1";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't the version changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh shoot, you're right; looks like I didnt push up that change

@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 108085 1

2 packages built:
  • docker-machine-kvm2
  • minikube

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/322

@zowoq zowoq merged commit 43f84e1 into NixOS:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@copumpkin copumpkin Awaiting requested review from copumpkin

@vdemeester vdemeester Awaiting requested review from vdemeester

@ebzzry ebzzry Awaiting requested review from ebzzry

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Chili-Man @thiagokokada @nixos-discourse @zowoq