Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup 2db88953e7: Remove VL_FIRST_SORT as it's useless #8472

Merged
merged 1 commit into from Jan 1, 2021
Merged

Cleanup 2db88953e7: Remove VL_FIRST_SORT as it's useless #8472

merged 1 commit into from Jan 1, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Dec 31, 2020

Motivation / Problem

VL_FIRST_SORT original use was to sort with quick sort first, then gsort.
In 2db8895, both qsort and gsort were replaced by std::sort, so VL_FIRST_SORT has no effect.

Description

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

LordAro
LordAro approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISTR noticing this at the time. I presume renumbering the enum won't cause any issues (nothing saved or anything?)

@glx22 glx22 merged commit 7222bc5 into OpenTTD:master Jan 1, 2021
@glx22 glx22 deleted the cleanup branch January 1, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glx22 @LordAro