Fixes for issues with rotated (non-rectangular) airports #8458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
added
candidate: yes
|
@TrueBrain What does the label "needs review: mad man" even mean? |
Exactly what it says: we need a mad man to review this PR. We already had one mad men making this PR ... only fair if another one does reviewing. |
TrueBrain
reviewed
Jan 3, 2021
… drawn at the wrong height Only the rotated intercontinental airport, don't get excited
LordAro
force-pushed
the
bug8437
branch
2 times, most recently
from
a3ee01c
to
922cc39
Compare
TrueBrain
approved these changes
Jan 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
#8437
Description
First issue is caused by assumptions that the airport tile is the same tile as the rest of the airport/runway. Obviously the case in almost every case... except for the rotated (180deg) intercontinental airport
Second issue is again only an issue for rotated intercontinental, but seems to boil down to oilrigs being hacks - the "tile" that the aircraft/helicopter is landing at is always the airport tile, purely because the oilrig is actually only a 1x1 airport, pretending to be 2x2. Essentially, the fix for this just expands the special case that's already in place lower down (which doesn't actually seem to get triggered for oilrigs at all anyway
OpenTTD/src/aircraft_cmd.cpp
Lines 1037 to 1038 in edbb5f4
Limitations
More hacks upon hacks.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.