Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix string escaping #108086

Closed
wants to merge 8 commits into from
Closed

fix string escaping #108086

wants to merge 8 commits into from

Conversation

kvtb
Copy link
Contributor

@kvtb kvtb commented Dec 31, 2020 •
edited

Sequences like "\." and "\@" are wacky within single quoted strings, there must be either "." or "\\."

@kvtb
kresd.nix: fix string escaping
0c8f5c0 
\+ has no effect in single quoted strings
@kvtb
docuwiki.nix: fix string escaping
2c7f09a 
\. has no effect in single quoted strings
@kvtb
fpm.nix: fix string escaping
2d6926b 
\. has no effect in single quoted strings
@kvtb
build-bazel-package: fix string escaping
73853d0 
\@ has no effect in single quoted strings
@kvtb
libcutl: fix string escaping
8597705 
\. has no effect in single quoted strings
@kvtb
poetry2nix: fix string escaping
45c3ba8 
\[ has no effect in single quoted strings
@kvtb
poetry2nix: fix string escaping
8d09e79 
\. \* \^ have no effect in single quoted strings
@kvtb kvtb changed the title fix strig escaping fix string escaping Dec 31, 2020
@kvtb
Update pkgs/development/libraries/libcutl/default.nix
53d60cf 
Co-authored-by: Louis Bettens <lourkeur@users.noreply.github.com>
@taku0
Copy link
Contributor

taku0 commented Feb 13, 2021

Please squash Update pkgs/development/libraries/libcutl/default.nix and libcutl: fix string escaping, then I will merge this.

@taku0
Copy link
Contributor

taku0 commented Feb 28, 2021

@kvtb ping

@kvtb
Copy link
Contributor Author

kvtb commented Mar 1, 2021

I cannot, I have no full nixpkgs git repo locally (checking out will eat monthly packet of mobile Internet) and GitHub web ui has no squash

@taku0
Copy link
Contributor

taku0 commented Mar 2, 2021

@kvtb could you allow us to edit your branch? I will try to squash and (force-)push if I can.

@kvtb
Copy link
Contributor Author

kvtb commented Mar 2, 2021

@kvtb could you allow us to edit your branch? I will try to squash and (force-)push if I can.

I see this checkbox on my other two PRs, but not on this one.
And kvtb:patch-2 above is just text, not link to https://github.com/kvtb/nixpkgs/tree/patch-2. In another PR, kvtb:patch-3 is a link.
May be better kill this PR and make new one.

@kvtb
Copy link
Contributor Author

kvtb commented Mar 2, 2021

Interesting, https://github.com/kvtb/nixpkgs/tree/patch-2 does not have commits from this PR.
So this PR is effectively branchless.

@bbjubjub2494
Copy link
Member

true.

I grabbed refs/pull/108086/head an went to rebase. Thank you for your work!

@bbjubjub2494 bbjubjub2494 mentioned this pull request Mar 2, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbjubjub2494 bbjubjub2494 bbjubjub2494 left review comments

@taku0 taku0 taku0 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kvtb @taku0 @bbjubjub2494 @SuperSandro2000