Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.cfn-lint: future-proof tests for date impurity issues #108079

Merged
merged 1 commit into from Jan 5, 2021

Conversation

rmcgibbo
Copy link
Contributor

Motivation for this change

Fixes #108076

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Can you please take another look at this after #105658 merged?

@rmcgibbo
Copy link
Contributor Author

rmcgibbo commented Jan 1, 2021

I checked master after the merge of #105658, and although it currently passes, the tests are going to fail 6 months from now because of an embedded date check that will trigger then.

(Tested with

  checkPhase = ''
    PATH=$out/bin:$PATH ${libfaketime}/bin/faketime "2021-07-01 20:30:00" pytest -k "not test_update_docs"
  '';

)

I'll rebase this PR against master to disable those particular tests again.

@rmcgibbo rmcgibbo changed the title pyton3Packages.cfn-lint: unbreak for new year pyton3Packages.cfn-lint: future-proof tests for date impurity issues Jan 1, 2021
@SuperSandro2000 SuperSandro2000 changed the title pyton3Packages.cfn-lint: future-proof tests for date impurity issues python3Packages.cfn-lint: future-proof tests for date impurity issues Jan 5, 2021
@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108079 run on x86_64-linux 1

1 package built:
  • python38Packages.cfn-lint

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108079 run on x86_64-darwin 1

1 package built:
  • python3Packages.cfn-lint

@SuperSandro2000 SuperSandro2000 merged commit 4a91df5 into NixOS:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python3Packages.cfn-lint broken by New Year
3 participants