Skip to content

nixos/shiori: fix SystemCallFilter after libseccomp update #108160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2021
Merged

nixos/shiori: fix SystemCallFilter after libseccomp update #108160

merged 1 commit into from
Apr 3, 2021
+2 −2

Conversation

minijackson
Copy link
Member

fixes #108146.

@aswan89 can you confirm that it works for you?

Motivation for this change

The shiori module is currently broken on master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 1, 2021
@aswan89
Copy link

aswan89 commented Jan 1, 2021

Using this new version of the module has eliminated the error I ran in to in #108146

@minijackson
Copy link
Member Author

@ofborg test shiori

@bryanasdev000
Copy link
Member

Up

@minijackson
Copy link
Member Author

minijackson commented Apr 2, 2021 •
edited
Loading

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 label Apr 2, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Apr 2, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the awaiting_reviewer (old Marvin label, do not use) label Apr 2, 2021
@minijackson
Copy link
Member Author

/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added needs_reviewer (old Marvin label, do not use) and removed awaiting_reviewer (old Marvin label, do not use) labels Apr 2, 2021
@marvin-mk2 marvin-mk2 bot requested a review from bennyandresen April 2, 2021 12:22
@marvin-mk2 marvin-mk2 bot added awaiting_reviewer (old Marvin label, do not use) and removed needs_reviewer (old Marvin label, do not use) labels Apr 2, 2021
bryanasdev000
bryanasdev000 approved these changes Apr 3, 2021
View reviewed changes
Copy link
Member

@bryanasdev000 bryanasdev000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested on my VPS, LGTM.

@minijackson
Copy link
Member Author

/status needs_merger

@marvin-mk2
Copy link

marvin-mk2 bot commented Apr 3, 2021

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@bryanasdev000
Copy link
Member

/status needs_merger

@marvin-mk2 marvin-mk2 bot added needs_merger (old Marvin label, do not use) and removed awaiting_reviewer (old Marvin label, do not use) labels Apr 3, 2021
@marvin-mk2 marvin-mk2 bot requested a review from kevincox April 3, 2021 09:11
@marvin-mk2 marvin-mk2 bot added awaiting_merger (old Marvin label, do not use) and removed needs_merger (old Marvin label, do not use) labels Apr 3, 2021
@kevincox kevincox merged commit 8442c21 into NixOS:master Apr 3, 2021
@minijackson minijackson deleted the shiori-fix-syscall-filters branch April 3, 2021 10:53
cideM pushed a commit to cideM/nixpkgs that referenced this pull request Apr 9, 2021
@minijackson @cideM
nixos/shiori: fix SystemCallFilter after libseccomp update (NixOS#108160
f33108b 
)

fixes NixOS#108146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanasdev000 bryanasdev000

@bennyandresen bennyandresen

@kevincox kevincox

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux awaiting_merger (old Marvin label, do not use) marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2
Projects
None yet
Milestone
No milestone
4 participants
@minijackson @aswan89 @bryanasdev000 @kevincox