Use cargoHash in buildRustPackage crates with SRI hashes #108121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you forgot to commit something? |
I don't think so? Like the description says, this commit changes derivations that use |
|
@danieldk please fix the merge conflict. |
danieldk
force-pushed
the
sri-to-cargo-hash
branch
from
275a294
to
bac1600
Compare
|
@SuperSandro2000 rebased |
| @@ -18,7 +18,7 @@ let | |||
| # 3) run the ./result script that is output by that (it updates ./grammars) | |||
| version = "0.17.3"; | |||
| sha256 = "sha256-uQs80r9cPX8Q46irJYv2FfvuppwonSS5HVClFujaP+U="; | |||
| cargoSha256 = "sha256-fonlxLNh9KyEwCj7G5vxa7cM/DlcHNFbQpp0SwVQ3j4="; | |||
| cargoHash = "sha256-fonlxLNh9KyEwCj7G5vxa7cM/DlcHNFbQpp0SwVQ3j4="; | |||
There was a problem hiding this comment.
This would need a change in line 65, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
We now have
cargoHash(as a replacement forcargoSha256) for SRIhashes. So, use it in derivations that use a SRI hash for vendored
Cargo dependencies.
This change does not update rust-analyzer. It also requires changing
the update script, which relies on nix-prefetch, which returns non-SRI
hashes (didn't have time to look deeper). (@oxalica)
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)