python3Packages.pycapnp fixes #108088
Merged
python3Packages.pycapnp fixes #108088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
requested changes
Jan 1, 2021
lukeadams
force-pushed
the
pycapnp-fixes
branch
2 times, most recently
from
95099d2
to
1507e8f
Compare
|
@SuperSandro2000 Made changes as requested. I'm just going to leave the tests alone since building from source just for the tests is a lot of trouble. |
lukeadams
force-pushed
the
pycapnp-fixes
branch
from
1507e8f
to
212c450
Compare
lukeadams
force-pushed
the
pycapnp-fixes
branch
2 times, most recently
from
5e3581d
to
92e3a50
Compare
added 2 commits
January 1, 2021 16:21
…nput Dependent packages require pkg-config. Remove test-related overrides. Next version will include tests in the PyPi dist so there isn't much benefit to building from source just for that.
Also: - Disabled Py27: New versions don't support it - Fetch from github repo instead of PyPi
lukeadams
force-pushed
the
pycapnp-fixes
branch
from
92e3a50
to
6c9f17e
Compare
SuperSandro2000
approved these changes
Jan 1, 2021
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
SuperSandro2000
approved these changes
Jan 6, 2021
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
pycapnp was marked as broken. That is now resolved.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)