[staging-next] gnutls: fix build on darwin #108087
Closed
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incompatible with staged update to autoconf 2.70. No effect on linux as autoconf is only needed on darwin.
r-burns
changed the title
ofborg
bot
added
10.rebuild-darwin: 501+
10.rebuild-darwin: 1001-2500
10.rebuild-linux: 0
|
Inkscape builds now. More dependencies of qtmultimedia are building but libpulseaudio fails |
FRidh
reviewed
Jan 1, 2021
| @@ -13352,6 +13352,7 @@ in | |||
| gnutls = callPackage ../development/libraries/gnutls/default.nix { | |||
| inherit (darwin.apple_sdk.frameworks) Security; | |||
| util-linux = util-linuxMinimal; # break the cyclic dependency | |||
| autoconf = autoconf269; | |||
There was a problem hiding this comment.
Please use buildPackages.autoconf269 to not break cross
There was a problem hiding this comment.
All the other pins in all-packages use autoconf = autoconf269;, is that going to cause problems? I see that autoreconfHook is made to use buildPackages but not so for autoconf itself
There was a problem hiding this comment.
See bf46afd, this should be done for all nativeBuildInputs that are called with an explicit argument.
There was a problem hiding this comment.
made the treewide change in 136c0d0
|
pushed this change as b095078 with buildPackages |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incompatible with staged update to autoconf 2.70.
No effect on linux as autoconf is only needed on darwin.
cc @FRidh
Motivation for this change
#107783
https://hydra.nixos.org/build/133918690
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)