Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove maintainership of ma27 from a few packages #108126

Merged
merged 2 commits into from Jan 2, 2021

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 1, 2021

Motivation for this change

Those are packages I don't use anymore for a longer time and I therefore
don't think that listing me as maintainer is a good idea. If those
should be removed now, I'd be fine with that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add me to chkcrontab, yowsup and pyaxmlparser.

@@ -21,6 +21,6 @@ buildPythonPackage rec {
description = " Structure-aware diff for html and xml documents";
homepage = "https://github.com/christian-oudard/htmltreediff";
license = licenses.bsdOriginal;
maintainers = with maintainers; [ ma27 ];
maintainers = with maintainers; [ ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project did not receive any commits for 10 years. I think this can be potentially removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for a python package, that is especially bad

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the guideline on removing packages? What about projects in compiled languages written in C last updated in 2004, for instance?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siraben if it's still working and providing utility to someone, IMO we should keep it around "forever". If something hasn't broken in 16 years, which would it break now?

Those are packages I don't use anymore for a longer time and I therefore
don't think that listing me as maintainer is a good idea. If those
should be removed now, I'd be fine with that.

SuperSandro2000 will take care of a few packages[1].

[1] NixOS#108126 (review)
Not used anywhere and also not updated for a long time.
@Ma27
Copy link
Member Author

Ma27 commented Jan 1, 2021

Addressed both of your comments @SuperSandro2000 , thanks!

@Ma27 Ma27 merged commit 097cd34 into NixOS:master Jan 2, 2021
@Ma27 Ma27 deleted the cleanup-maintained-pkgs branch January 2, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants