treewide: remove maintainership of ma27 from a few packages
#108126
Merged
+6
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: python
10.rebuild-darwin: 0
| @@ -21,6 +21,6 @@ buildPythonPackage rec { | |||
| description = " Structure-aware diff for html and xml documents"; | |||
| homepage = "https://github.com/christian-oudard/htmltreediff"; | |||
| license = licenses.bsdOriginal; | |||
| maintainers = with maintainers; [ ma27 ]; | |||
| maintainers = with maintainers; [ ]; | |||
There was a problem hiding this comment.
This project did not receive any commits for 10 years. I think this can be potentially removed.
There was a problem hiding this comment.
for a python package, that is especially bad
There was a problem hiding this comment.
What's the guideline on removing packages? What about projects in compiled languages written in C last updated in 2004, for instance?
There was a problem hiding this comment.
@siraben if it's still working and providing utility to someone, IMO we should keep it around "forever". If something hasn't broken in 16 years, which would it break now?
Those are packages I don't use anymore for a longer time and I therefore don't think that listing me as maintainer is a good idea. If those should be removed now, I'd be fine with that. SuperSandro2000 will take care of a few packages[1]. [1] NixOS#108126 (review)
Not used anywhere and also not updated for a long time.
Ma27
force-pushed
the
cleanup-maintained-pkgs
branch
from
00a1962 to
0d3f7b6
Compare
|
Addressed both of your comments @SuperSandro2000 , thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Those are packages I don't use anymore for a longer time and I therefore
don't think that listing me as maintainer is a good idea. If those
should be removed now, I'd be fine with that.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)