Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

direnv: 2.25.1 -> 2.27.0 #108125

Merged
merged 1 commit into from Jan 1, 2021
Merged

direnv: 2.25.1 -> 2.27.0 #108125

merged 1 commit into from Jan 1, 2021

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Jan 1, 2021

Motivation for this change

update!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zimbatm
Copy link
Member Author

zimbatm commented Jan 1, 2021

Result of nixpkgs-review pr 108125 run on x86_64-linux 1

2 packages built:
  • direnv
  • vimPlugins.direnv-vim

zowoq
zowoq approved these changes Jan 1, 2021
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs on darwin/nixos.

@ofborg ofborg bot requested a review from kalbasit January 1, 2021 13:46
@kalbasit kalbasit merged commit 1996ff7 into NixOS:master Jan 1, 2021
@zimbatm zimbatm deleted the direnv-2.27.0 branch January 1, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@zowoq zowoq zowoq approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimbatm @kalbasit @zowoq