Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.py-air-control-exporter: add passthru.tests #108123

Merged
merged 1 commit into from Jan 3, 2021
Merged

python3Packages.py-air-control-exporter: add passthru.tests #108123

merged 1 commit into from Jan 3, 2021

Conversation

urbas
Copy link
Contributor

@urbas urbas commented Jan 1, 2021

This change adds integration tests to the py-air-control-exporter package. These tests verify that the exporter exports metrics correctly in an actual NixOS virtual machine.

Motivation for this change

To have better coverage of the exporter in CI.

Things done

Output of nix run nixpkgs.nixpkgs-review -c nixpkgs-review rev HEAD:

Result of `nixpkgs-review` run on x86_64-linux [1](https://github.com/Mic92/nixpkgs-review)
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@urbas
python3Packages.py-air-control-exporter: add passthru.tests
49d63b5 
This change adds integration tests to the py-air-control-exporter package. These tests verify that the exporter exports metrics correctly in an actual NixOS virtual machine.
@urbas
Copy link
Contributor Author

urbas commented Jan 1, 2021

Result of nixpkgs-review pr 108123 run on x86_64-linux 1

@lukegb
Copy link
Contributor

lukegb commented Jan 1, 2021

@ofborg test prometheus-exporters.py-air-control

@symphorien symphorien merged commit e95ef6a into NixOS:master Jan 3, 2021
@urbas urbas deleted the py-air-control-passthru-tests branch January 3, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urbas @lukegb @SuperSandro2000 @symphorien