Skip to content

dwm-git: 20180602 -> 20200303 #108150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2021
Merged

dwm-git: 20180602 -> 20200303 #108150

merged 1 commit into from
Feb 7, 2021
+14 −15

Conversation

ivankovnatsky
Copy link
Contributor

@ivankovnatsky ivankovnatsky commented Jan 1, 2021 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ivankovnatsky ivankovnatsky force-pushed the patch-8 branch 5 times, most recently from 7ee7163 to cc1de1f Compare January 1, 2021 18:19
@ivankovnatsky
Copy link
Contributor Author 

nixpkgs-review pr 108150

1 package built:
dwm-git

@ofborg ofborg bot requested a review from xeji January 1, 2021 18:28
@ivankovnatsky ivankovnatsky marked this pull request as ready for review January 1, 2021 18:39
SuperSandro2000
SuperSandro2000 requested changes Jan 1, 2021
View reviewed changes
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108150 run on x86_64-linux 1

1 package built:
  • dwm-git

Please do not overwrite the buildPhase with make. make is automatically executed.

@SuperSandro2000
Copy link
Member

Please squash the suggestions together.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108150 run on x86_64-darwin 1

1 package built:
  • dwm-git

@ivankovnatsky ivankovnatsky force-pushed the patch-8 branch 4 times, most recently from 4fe9524 to 6d0771b Compare January 3, 2021 12:17
@ivankovnatsky
Copy link
Contributor Author

should be good, i see that gh shows some requested changes, but it should be already resolved.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108150 run on x86_64-darwin 1

1 package built:
  • dwm-git

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108150 run on x86_64-linux 1

1 package built:
  • dwm-git

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/344

cole-h
cole-h approved these changes Feb 7, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, thanks!

Result of nixpkgs-review pr 108150 run on x86_64-linux 1

1 package built:
  • dwm-git

@cole-h cole-h merged commit 8d1f23c into NixOS:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000

@cole-h cole-h

@xeji xeji

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ivankovnatsky @SuperSandro2000 @nixos-discourse @cole-h