Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.channels-redis: 2.4.0 -> 3.2.0 #107392

Merged
merged 1 commit into from Jan 1, 2021
Merged

python3Packages.channels-redis: 2.4.0 -> 3.2.0 #107392

merged 1 commit into from Jan 1, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Dec 22, 2020

Motivation for this change

Update to latest upstream release 3.2.0

Changelog: https://github.com/django/channels_redis/blob/master/CHANGELOG.txt

Should fix the build issue that came up during update for msgpack.

  ERROR: Could not find a version that satisfies the requirement channels~=2.2 (from channels-redis)
  ERROR: No matching distribution found for channels~=2.2exit
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Dec 22, 2020

Result of nixpkgs-review pr 107392 run on x86_64-linux 1

3 packages failed to build:
  • python37Packages.channels-redis
  • python38Packages.channels-redis
  • python39Packages.channels-redis

@ofborg ofborg bot requested a review from mmai December 22, 2020 11:31
@fabaff
Copy link
Member Author

fabaff commented Dec 22, 2020

Related #107390

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107392 run on x86_64-darwin 1

3 packages failed to build:
  • python37Packages.channels-redis
  • python38Packages.channels-redis
  • python39Packages.channels-redis

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107392 run on x86_64-linux 1

3 packages failed to build:
  • python37Packages.channels-redis
  • python38Packages.channels-redis
  • python39Packages.channels-redis

@SuperSandro2000
Copy link
Member

Next time please put this into the other PR.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107392 run on x86_64-darwin 1

3 packages built:
  • python37Packages.channels-redis
  • python38Packages.channels-redis
  • python39Packages.channels-redis
Ran 0 tests in 0.000s

Please add doCheck = false; and a pythonImportsCheck.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107392 run on x86_64-linux 1

3 packages built:
  • python37Packages.channels-redis
  • python38Packages.channels-redis
  • python39Packages.channels-redis

@fabaff
Copy link
Member Author

fabaff commented Dec 28, 2020

Please add doCheck = false; and a pythonImportsCheck.

Added

@fabaff fabaff mentioned this pull request Jan 1, 2021
Merged
jonringer
jonringer approved these changes Jan 1, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/107392

3 packages built:
python37Packages.channels-redis python38Packages.channels-redis python39Packages.channels-redis

@jonringer jonringer merged commit 80c1675 into NixOS:master Jan 1, 2021
@fabaff fabaff deleted the channels-redis branch January 1, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@mmai mmai Awaiting requested review from mmai

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @SuperSandro2000 @jonringer