Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audacity: switch to cmake to fix missing plug-ins #107465

Merged
merged 1 commit into from Jan 1, 2021
Merged

audacity: switch to cmake to fix missing plug-ins #107465

merged 1 commit into from Jan 1, 2021

Conversation

Gerschtli
Copy link
Contributor

Motivation for this change

The share/audacity/plug-ins directory was missing, because the audacity project changed to cmake.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from lheckemann December 23, 2020 13:02
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 23, 2020 •
edited

Please match the PR title and the commit message title to something like:

audacity: switch to cmake to fix missing plugins

SuperSandro2000
SuperSandro2000 requested changes Dec 23, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove enableParallelBuilding = true; because cmake already sets this.

SuperSandro2000
SuperSandro2000 reviewed Dec 24, 2020
View reviewed changes
pkgs/applications/audio/audacity/default.nix
'';

configureFlags = [
"--with-libsamplerate"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional that this is dropped?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, this seems to be the default now.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107465 run on x86_64-darwin 1

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107465 run on x86_64-linux 1

1 package built:
  • audacity

@SuperSandro2000 SuperSandro2000 changed the title Fix missing plug-ins in audacity audacity: switch to cmake to fix missing plug-ins Dec 27, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107465 run on x86_64-linux 1

1 package built:
  • audacity

@TredwellGit
Copy link
Member

#97370

@SuperSandro2000 SuperSandro2000 merged commit 9f33d65 into NixOS:master Jan 1, 2021
@Gerschtli Gerschtli deleted the fix/audacity branch November 28, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@lheckemann lheckemann Awaiting requested review from lheckemann

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gerschtli @SuperSandro2000 @TredwellGit