Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup-hooks/strip: silence 'File format not recognized' errors again #108081

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the commit message to at least point to e4d17dc where this change was lost.

@SuperSandro2000 SuperSandro2000 force-pushed the silence-file-format-not-recognized branch from 07d0f95 to 03ba885 Compare January 2, 2021 09:46
@SuperSandro2000
Copy link
Member Author

Please fix the commit message to at least point to e4d17dc where this change was lost.

added

@SuperSandro2000 SuperSandro2000 merged commit 7ff9b36 into NixOS:staging Jan 6, 2021
@SuperSandro2000 SuperSandro2000 deleted the silence-file-format-not-recognized branch January 6, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants