Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 0fd1192132ab
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 5e9d92c83922
Choose a head ref
  • 3 commits
  • 7 files changed
  • 2 contributors

Commits on Jan 1, 2021

  1. grafana-image-renderer: init at 2020-12-01 

    This package[1] is a replacement for the old phantomjs-integration[2]
which is practically EOL. It is basically used to render PNGs of panels
that triggered an alert in Grafana.

This package internally uses `puppeteer`[3] to control a headless
Chromium instance. Even though puppeteer recommends to use a fixed
revision of `chromium`, I checked that our default `pkgs.chromium` works
fine as well. Also, I don't think it's a good idea to use outdated
browser versions[4].

I used the latest revision from `master` on purpose since compiling the
code with `tsc` from `v2.0` didn't work and I couldn't figure out why.

[1] https://grafana.com/grafana/plugins/grafana-image-renderer
[2] https://grafana.com/blog/2020/05/07/grafana-7.0-preview-new-image-renderer-plugin-to-replace-phantomjs/
[3] https://github.com/puppeteer/puppeteer
[4] currently, puppeteer v2.0.0 is used which recommends revision 706915
    (v79.0.3945.130).
    @Ma27
    Ma27 committed Jan 1, 2021
    Copy the full SHA
    a9d0682 View commit details
    Browse the repository at this point in the history

  2. nixos/grafana-image-renderer: init

    @Ma27
    Ma27 committed Jan 1, 2021
    Copy the full SHA
    ca2a675 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #108142 from Ma27/grafana-img-renderer 

    grafana-image-renderer: init at 2020-12-01
    @WilliButz
    WilliButz committed Jan 1, 2021
    Copy the full SHA
    5e9d92c View commit details
    Browse the repository at this point in the history