Skip to content

freeplane: init at 1.8.11 #108092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2021
Merged

freeplane: init at 1.8.11 #108092

merged 1 commit into from
Mar 20, 2021
+120 −0

Conversation

charles-dyfis-net
Copy link
Contributor

Motivation for this change

The freemind package has been effectively unmaintained for years -- the most recent release is from 2014.

freeplane is an actively-maintained fork, written by @dpolivaev. In addition to substantial feature improvements, it also has received security fixes.

There was a prior attempt at packaging freeplane made in #34752; this was not completed due to difficulties in getting freeplane to compile in a sandbox without network access. This derivation adopts the pattern used by pdftk and jadx, performing download of dependencies inside fixed-output derivations.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@charles-dyfis-net
Copy link
Contributor Author

@razvan-flavius-panda, if you have any feedback (as the author of the prior freeplane PR), 'twould be welcome.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jan 1, 2021
SuperSandro2000
SuperSandro2000 reviewed Jan 1, 2021
View reviewed changes
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 1, 2021
@charles-dyfis-net
Copy link
Contributor Author

@SuperSandro2000, updated per feedback, thank you.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108092 run on x86_64-linux 1

1 package built:
  • freeplane

thiagokokada
thiagokokada reviewed Jan 2, 2021
View reviewed changes
pkgs/applications/misc/freeplane/default.nix
description = "Mind-mapping software";
homepage = "https://freeplane.org/";
license = licenses.gpl2Plus;
platforms = platforms.linux;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering this is a Java package, it should work in macOS too right 🤔 ?

@maxhbr maxhbr mentioned this pull request Mar 3, 2021
Closed
10 tasks
@maxhbr
Copy link
Member

maxhbr commented Mar 3, 2021

Hey, I have a related PR #113935 that tries to package 1.8.11. We should merge our efforts

@charles-dyfis-net
Copy link
Contributor Author

charles-dyfis-net commented Mar 4, 2021 •
edited
Loading

Per @maxhbr above:

Hey, I have a related PR #113935 that tries to package 1.8.11. We should merge our efforts

Agreed. Insofar as this package is building from source and the other is packaging binaries, I would tend to lean towards closing the other in favor of this one (as following the better-practice approach -- and more flexible, should we need to patch anything in the future).

Do you concur?

rmcgibbo
rmcgibbo reviewed Mar 16, 2021
View reviewed changes
Copy link
Contributor

@rmcgibbo rmcgibbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed trace: Warning: stdenv.libis deprecated and will be removed in the next release. Please uselib instead. For more information see https://github.com/NixOS/nixpkgs/issues/108938 while building.

Otherwise built fine on x86_64-linux and app boots up & works.

@charles-dyfis-net charles-dyfis-net changed the title freeplane: init at 1.8.10 freeplane: init at 1.8.11 Mar 20, 2021
@SuperSandro2000
Copy link
Member

Per @maxhbr above:

Hey, I have a related PR #113935 that tries to package 1.8.11. We should merge our efforts

Agreed. Insofar as this package is building from source and the other is packaging binaries, I would tend to lean towards closing the other in favor of this one (as following the better-practice approach -- and more flexible, should we need to patch anything in the future).

Do you concur?

Whats the status on this? Otherwise LGTM and we could merge it.

@maxhbr
Copy link
Member

maxhbr commented Mar 20, 2021

LGTM, should be merged!

tomberek
tomberek approved these changes Mar 20, 2021
View reviewed changes
@SuperSandro2000 SuperSandro2000 merged commit eede818 into NixOS:master Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmcgibbo rmcgibbo

@thiagokokada thiagokokada

@tomberek tomberek

@SuperSandro2000 SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@charles-dyfis-net @SuperSandro2000 @maxhbr @tomberek @rmcgibbo @thiagokokada