Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] thunderbird: Add gpg/gpgme dependencies to fix smartcard usage #108157

Merged
merged 2 commits into from
Jan 1, 2021
Merged

[20.09] thunderbird: Add gpg/gpgme dependencies to fix smartcard usage #108157

merged 2 commits into from
Jan 1, 2021
+20 −1

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jan 1, 2021

Motivation for this change

Backport of #107122

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

nh2 added 2 commits January 1, 2021 20:39
@nh2
thunderbird: Add gpg/gpgme dependencies. Fixes NixOS#98765.
8c2bcac 
This enables to configure Thunderbird to use gnupg directly, which is the
official upstream recommendation when using GPG with smartcards, which are not
yet supported by Thunderbird's native GPG support.

(cherry picked from commit 2767936)
@nh2
thunderbird-bin: Add gpg/gpgme dependencies. Fixes NixOS#98765
64037af 
(cherry picked from commit e72bd9f)
@nh2 nh2 requested review from taku0 and lovesegfault January 1, 2021 19:41
@nh2 nh2 self-assigned this Jan 1, 2021
@ofborg ofborg bot requested review from edolstra, nbp and vcunat January 1, 2021 19:51
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 1, 2021
@lovesegfault lovesegfault merged commit e1cb4bf into NixOS:release-20.09 Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault

@taku0 taku0

@edolstra edolstra

@nbp nbp

@vcunat vcunat

Assignees

@nh2 nh2

Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @lovesegfault