Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

root: 6.18.04 -> 6.22.06, don't build vendored LLVM #107335

Merged
merged 6 commits into from Jan 1, 2021
Merged

root: 6.18.04 -> 6.22.06, don't build vendored LLVM #107335

merged 6 commits into from Jan 1, 2021

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Dec 21, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@veprbl veprbl changed the title Pr/root 6 20 08 root: 6.18.04 -> 6.20.08 Dec 21, 2020
@veprbl veprbl changed the title root: 6.18.04 -> 6.20.08 root: 6.18.04 -> 6.22.06 Dec 21, 2020
@veprbl veprbl changed the title root: 6.18.04 -> 6.22.06 root: 6.18.04 -> 6.22.06, don't use vendored LLVM Dec 21, 2020
@veprbl veprbl changed the title root: 6.18.04 -> 6.22.06, don't use vendored LLVM root: 6.18.04 -> 6.22.06, don't build vendored LLVM Dec 22, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107335 run on x86_64-darwin 1

13 packages marked as broken and skipped:
  • chipmunk
  • dolphinEmuMaster
  • gplates
  • kicad-small
  • kicad-unstable-small
  • libretro.dolphin
  • maim
  • openmsx
  • python37Packages.kicad
  • python38Packages.kicad
  • python39Packages.kicad
  • yaxg
  • yoda-with-root
2 packages failed to build:
  • openhmd
  • pymol
21 packages built:
  • blender
  • bzflag
  • ccextractor
  • fastnlo
  • glew
  • glew110
  • gource
  • hepmc3
  • hyperrogue
  • libAfterImage
  • opencsg
  • openrw
  • openscad
  • openspades
  • opensubdiv
  • pangolin
  • python37Packages.hepmc3
  • python38Packages.hepmc3
  • python39Packages.hepmc3
  • root
  • sfml

openhmd

1 warning generated.
1 warning generated.
[ 88%] Linking C shared library libopenhmd.dylib
[ 90%] Linking C static library libopenhmd.a
ld: library not found for -lrt
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [CMakeFiles/openhmd-shared.dir/build.make:440: libopenhmd.0.1.0.dylib] Error 1
make[1]: *** [CMakeFiles/Makefile2:165: CMakeFiles/openhmd-shared.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
/nix/store/qyzf1mh6ah2lqaffrg2xwfncrmpswqzm-cctools-port-949.0.1/bin/ranlib: file: libopenhmd.a(platform-win32.c.o) has no symbols
/nix/store/jp0bhf9dxx9n324hm24rr3nhcggib1f2-cctools-binutils-darwin-949.0.1/bin/ranlib: file: libopenhmd.a(platform-win32.c.o) has no symbols
[ 90%] Built target openhmd-static
make: *** [Makefile:149: all] Error 2

pymol

layer0/os_gl.h:144:9: fatal error: 'GLUT/glut.h' file not found
#import <GLUT/glut.h>
        ^~~~~~~~~~~~~
1 error generated.
clang++ -std=c++11 -D_PYMOL_LIBPNG -D_PYMOL_FREETYPE -D_PYMOL_INLINE -D_PYMOL_VMD_PLUGINS -D_HAVE_LIBXML -D_PYMOL_NO_MSGPACKC -D_PYMOL_OSX -D_PYMOL_NUMPY -Icontrib/uiuc/plugins/include -I>clang++ -std=c++11 -D_PYMOL_LIBPNG -D_PYMOL_FREETYPE -D_PYMOL_INLINE -D_PYMOL_VMD_PLUGINS -D_HAVE_LIBXML -D_PYMOL_NO_MSGPACKC -D_PYMOL_OSX -D_PYMOL_NUMPY -Icontrib/uiuc/plugins/include -I>clang++ -std=c++11 -D_PYMOL_LIBPNG -D_PYMOL_FREETYPE -D_PYMOL_INLINE -D_PYMOL_VMD_PLUGINS -D_HAVE_LIBXML -D_PYMOL_NO_MSGPACKC -D_PYMOL_OSX -D_PYMOL_NUMPY -Icontrib/uiuc/plugins/include -I>In file included from layer4/Menu.cpp:26:
In file included from layer1/P.h:21:
In file included from layer2/AtomInfo.h:22:
In file included from layer1/Rep.h:21:
In file included from layer1/Ray.h:23:
In file included from layer1/Basis.h:20:
In file included from layer0/Map.h:24:
In file included from layer0/Vector.h:22:
layer0/os_gl.h:144:9: fatal error: 'GLUT/glut.h' file not found
#import <GLUT/glut.h>
        ^~~~~~~~~~~~~
1 error generated.
clang++ -std=c++11 -D_PYMOL_LIBPNG -D_PYMOL_FREETYPE -D_PYMOL_INLINE -D_PYMOL_VMD_PLUGINS -D_HAVE_LIBXML -D_PYMOL_NO_MSGPACKC -D_PYMOL_OSX -D_PYMOL_NUMPY -Icontrib/uiuc/plugins/include -I>clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -D_PYMOL_LIBPNG -D_PYMOL_FREETYPE -D_PYMOL_INLINE -D_PYMOL_VMD_PLUGINS -D_HAVE_LIBXML -D_PYMOL_NO_>clang-7: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
In file included from contrib/uiuc/plugins/molfile_plugin/src/pdbplugin.c:32:
contrib/uiuc/plugins/molfile_plugin/src/periodic_table.h:133:12: warning: unused function 'get_pte_idx' [-Wunused-function]
static int get_pte_idx(const char *label)
           ^
1 warning generated.
clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -D_PYMOL_LIBPNG -D_PYMOL_FREETYPE -D_PYMOL_INLINE -D_PYMOL_VMD_PLUGINS -D_HAVE_LIBXML -D_PYMOL_NO_>clang-7: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -D_PYMOL_LIBPNG -D_PYMOL_FREETYPE -D_PYMOL_INLINE -D_PYMOL_VMD_PLUGINS -D_HAVE_LIBXML -D_PYMOL_NO_>clang-7: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
error: command 'clang++' failed with exit status 1

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107335 run on x86_64-linux 1

1 package marked as broken and skipped:
  • yoda-with-root
7 packages built:
  • fastnlo
  • hepmc3
  • libAfterImage
  • python37Packages.hepmc3
  • python38Packages.hepmc3
  • python39Packages.hepmc3
  • root

@veprbl veprbl merged commit 8bee208 into NixOS:master Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @SuperSandro2000