Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libplacebo: 2.72.2 -> 3.104.0 #108155

Merged
merged 1 commit into from Jan 9, 2021
Merged

libplacebo: 2.72.2 -> 3.104.0 #108155

merged 1 commit into from Jan 9, 2021

Conversation

primeos
Copy link
Member

@primeos primeos commented Jan 1, 2021

Motivation for this change

This isn't ready yet. Seems like some breaking changes require a new mpv release:

[ 98/516] Compiling video/out/placebo/ra_pl.c
../video/out/placebo/ra_pl.c: In function ‘mppl_wrap_tex’:
../video/out/placebo/ra_pl.c:147:13: warning: ‘sample_mode’ is deprecated [-Wdeprecated-declarations]
  147 |             .src_linear = pltex->params.sample_mode == PL_TEX_SAMPLE_LINEAR,
      |             ^
In file included from ../video/out/placebo/ra_pl.h:4,
                 from ../video/out/placebo/ra_pl.c:4:
/nix/store/i8pw7slaskkkkifgww6xxpragxfykmhi-libplacebo-3.104.0/include/libplacebo/gpu.h:352:29: note: declared here
  352 |     enum pl_tex_sample_mode sample_mode PL_DEPRECATED;
      |                             ^~~~~~~~~~~
../video/out/placebo/ra_pl.c:148:13: warning: ‘address_mode’ is deprecated [-Wdeprecated-declarations]
  148 |             .src_repeat = pltex->params.address_mode == PL_TEX_ADDRESS_REPEAT,
      |             ^
In file included from ../video/out/placebo/ra_pl.h:4,
                 from ../video/out/placebo/ra_pl.c:4:
/nix/store/i8pw7slaskkkkifgww6xxpragxfykmhi-libplacebo-3.104.0/include/libplacebo/gpu.h:353:30: note: declared here
  353 |     enum pl_tex_address_mode address_mode PL_DEPRECATED;
      |                              ^~~~~~~~~~~~
../video/out/placebo/ra_pl.c: In function ‘blit_pl’:
../video/out/placebo/ra_pl.c:402:5: error: too many arguments to function ‘pl_tex_blit’
  402 |     pl_tex_blit(get_gpu(ra), dst->priv, src->priv, pldst, plsrc);
      |     ^~~~~~~~~~~
In file included from ../video/out/placebo/ra_pl.h:4,
                 from ../video/out/placebo/ra_pl.c:4:
/nix/store/i8pw7slaskkkkifgww6xxpragxfykmhi-libplacebo-3.104.0/include/libplacebo/gpu.h:458:6: note: declared here
  458 | void pl_tex_blit(const struct pl_gpu *gpu,
      |      ^~~~~~~~~~~

Waf: Leaving directory `/build/source/build'
Build failed
 -> task in 'objects' failed with exit status 1 (run with -v to display more information)
builder for '/nix/store/022m5a6k5nggr1bqrs0z4d4m3qzpw552-mpv-0.33.0.drv' failed with exit code 1
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos primeos marked this pull request as ready for review January 9, 2021 17:17
@primeos
Copy link
Member Author

primeos commented Jan 9, 2021

@ofborg build mpv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant