New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: remove trailing whitespace #108118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siraben
requested review from
adisbladis,
alyssais,
cdepillabout,
Ericson2314,
FRidh,
infinisil,
jonringer,
matthewbauer,
mmahut,
RaghavSood,
stigtsp and
ttuegel
as code owners
January 1, 2021 12:27
siraben
force-pushed
the
whitespace-cleanup
branch
from
January 1, 2021 12:27
5ff3332
to
42d741b
Compare
siraben
changed the title
treemode: remove trailing whitespace
treewide: remove trailing whitespace
Jan 1, 2021
ofborg
bot
added
6.topic: emacs
6.topic: erlang
6.topic: fetch
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: haskell
6.topic: nixos
6.topic: python
6.topic: qt/kde
6.topic: ruby
6.topic: stdenv
Standard environment
6.topic: TeX
Issues regarding texlive and TeX in general
6.topic: xfce
The Xfce Desktop Environment
8.has: changelog
8.has: documentation
8.has: module (update)
labels
Jan 1, 2021
siraben
force-pushed
the
whitespace-cleanup
branch
3 times, most recently
from
January 1, 2021 13:19
9196cd0
to
b25e269
Compare
Might be easier to use |
Ah, didn't know about that. Thanks. |
siraben
force-pushed
the
whitespace-cleanup
branch
from
January 1, 2021 13:23
b25e269
to
210e3c9
Compare
siraben
force-pushed
the
whitespace-cleanup
branch
from
January 1, 2021 13:47
210e3c9
to
ad0af02
Compare
$ nix-shell -p editorconfig-checker --run 'editorconfig-checker -disable-indent-size -disable-indent-size -disable-insert-final-newline -disable-indentation' | decolorize | grep -v '^[[:blank:]]' | cut -d':' -f1 | xargs sed -i '' -E "s/[[:space:]]*$//" |
ofborg
bot
removed
6.topic: TeX
Issues regarding texlive and TeX in general
6.topic: fetch
6.topic: python
6.topic: xfce
The Xfce Desktop Environment
8.has: documentation
labels
Jan 1, 2021
ofborg
bot
requested review from
spacekookie,
oxzi,
Pacman99,
bfortz and
obadz
and removed request for
infinisil and
bfortz
January 1, 2021 13:56
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
Jan 1, 2021
jonringer
approved these changes
Jan 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
failures are broken on target branch
2 packages failed to build:
apitrace minergate-cli
7 packages built:
deadd-notification-center firehol fusee-interfacee-tk keepass ly nanoblogger wavrsocvt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
We already do this check in ofborg, might as well apply it to all Nix files.
$ find . -name "*.nix" -type f -print0 | xargs -0 sed -i '' -E "s/[[:space:]]*$//"
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)