Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kinit: increase environment limit #107472

Merged
merged 1 commit into from Jan 2, 2021
Merged

kinit: increase environment limit #107472

merged 1 commit into from Jan 2, 2021

Conversation

CertainLach
Copy link
Contributor

Motivation for this change

Limit is already increased for standard xorg plasma distribution to
start, but with wayland, even more libraries being added

Increasing this limit to 1 << 20 (1M) seems to be enough (For me
length is 80K), and not so much for regular desktops

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CertainLach
kinit: increase environment limit
0fbd3e9 
Limit is already increased for standard xorg plasma distribution to
start, but with wayland, even more libraries being added

Increasing this limit to 1 << 20 (1M) seems to be enough (For me
length is 80K), and not so much for regular desktops

Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
@CertainLach CertainLach mentioned this pull request Dec 23, 2020
Merged
10 tasks
@oxalica
Copy link
Contributor

oxalica commented Dec 24, 2020

🤔 I'm wondering why there need to be a troublesome but increase-able limit. Can we simply throw away the check?

@CertainLach
Copy link
Contributor Author

@oxalica this check can prevent broken input from being passed to program, so it shouldn't be removed, i think.
Increasing it to 1M should be enough for a long time

@CertainLach CertainLach mentioned this pull request Dec 25, 2020
Closed
@ttuegel ttuegel merged commit ff47554 into NixOS:master Jan 2, 2021
@CertainLach CertainLach deleted the increase-kdeinit-environ-limit branch January 2, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CertainLach @oxalica @ttuegel