Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arduino-core: fix 'Save as...' #108216

Merged
merged 1 commit into from Jan 2, 2021
Merged

arduino-core: fix 'Save as...' #108216

merged 1 commit into from Jan 2, 2021

Conversation

raboof
Copy link
Member

@raboof raboof commented Jan 2, 2021 •
edited

Motivation for this change

Before, 'Save as..' would crash because it tries to use GSettings
to find some settings, but the GSettings schema's could not
be found in the XDG_DATA_DIRS.

Adding the glib setup hook populates GSETTINGS_SCHEMAS_PATH
so wrapGAppsHook can add it to XDG_DATA_DIRS, fixing
'Save as..'.

#100137

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof
arduino-core: fix 'Save as...'
e0a2307 
Before, 'Save as..' would crash because it tries to use GSettings
to find some settings, but the GSettings schema's could not
be found in the XDG_DATA_DIRS.

Adding the glib setup hook populates GSETTINGS_SCHEMAS_PATH
so wrapGAppsHook can add it to XDG_DATA_DIRS, fixing
'Save as..'.
@ofborg ofborg bot requested review from bergey and bjornfor January 2, 2021 11:59
raboof added a commit to raboof/nixpkgs that referenced this pull request Jan 2, 2021
@raboof
nixpkgs manual/gnome: clarify the glib setup hook
a8341ce 
Clarify loading the glib setup hook is not done automatically,
so to add the gsettings schema's to the XDG_DATA_DIRS you
will have to load it explicitly (like in
NixOS#108216)
@raboof raboof mentioned this pull request Jan 2, 2021
Closed
10 tasks
@bjornfor bjornfor merged commit cdd8031 into NixOS:master Jan 2, 2021
@bjornfor
Copy link
Contributor

bjornfor commented Jan 2, 2021

Thanks!

@Emantor Emantor mentioned this pull request Jun 10, 2021
Closed
@eliandoran eliandoran mentioned this pull request Dec 29, 2021
Closed
13 tasks
@eliandoran eliandoran mentioned this pull request Feb 11, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@bergey bergey Awaiting requested review from bergey

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raboof @bjornfor